Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align FirmwareInfo with esp_app_desc_t field size. #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

taunusflieger
Copy link

This PR addresses the differences (some fields are too small, one field is too large) in field sizes described in issue esp-rs/esp-idf-svc#204. It ensures, that the fields in FirmwareInfo are large enough to hold the fields defined in esp_app_desc_t. For details see the issue above.

@MabezDev
Copy link
Member

MabezDev commented Jan 3, 2023

embedded-svc is meant to be completely unaware of esp-idf, so I don't think we should be changing this struct to fit esp-idf's alignment needs unless there is another valid reason to do so. Instead, I think that esp-idf-svc should be handling the conversion from the esp-idf type, to the svc type.

If it turns out the embedded-svc struct is unfit for its purpose, we can change it. Thoughts @ivmarkov @zRedShift?

@ivmarkov
Copy link
Collaborator

embedded-svc is meant to be completely unaware of esp-idf, so I don't think we should be changing this struct to fit esp-idf's alignment needs unless there is another valid reason to do so. Instead, I think that esp-idf-svc should be handling the conversion from the esp-idf type, to the svc type.

If it turns out the embedded-svc struct is unfit for its purpose, we can change it. Thoughts @ivmarkov @zRedShift?

I agree. If there is some field in the embedded-svc struct which is too short, let's extend it, but 100% alignment is not what we are seeking out here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants