chore: remove dependency shelljs #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasttime
commented
Feb 23, 2024
| after(() => { | ||
| sh.rm("-r", fixtureDir); | ||
| after(async () => { | ||
| await fsp.rm(path.join(fixtureDir, "../../.."), { recursive: true }); |
There was a problem hiding this comment.
This should also remove "tmp" in the current directory, not just "tmp/eslint/fixtures/config-initializer".
nzakas
approved these changes
Feb 28, 2024
aladdin-add
reviewed
Feb 28, 2024
| @@ -8,11 +8,11 @@ | |||
| // Requirements | |||
| //------------------------------------------------------------------------------ | |||
|
|
|||
| import fsp from "node:fs/promises"; | |||
There was a problem hiding this comment.
We're rewriting it in another PR, and this file will be removed.
I can remove shelljs in that PR, thoughts?
There was a problem hiding this comment.
Sounds good 👍🏻 It looks like shelljs isn't used at all in that branch, so you could simply remove the package.json dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency shelljs and replaces its usages with native Node.js API calls in unit tests.
ShellJS in versions prior to 0.8.5 has a high rated vulnerability: https://nvd.nist.gov/vuln/detail/CVE-2022-0144.
Most Shelljs functions are synchronous, but for Node.js I/O operations it is recommended to use asynchronous functions, so I decided to use
fs/promises. We could also switch to the synchronous versions of those functions to stay in line with the usage in other parts of this repo.