-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove airbnb/google in style guides when using ts #33
Conversation
@@ -40,7 +40,8 @@ | |||
}, | |||
"mocha": { | |||
"loader": "esmock", | |||
"ui": "bdd" | |||
"ui": "bdd", | |||
"timeout": 10000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just set it a bigger value - a test was sometimes failing as timeout in my local.
79d47ca
to
abbb3b2
Compare
Now we'll have the following situation: the latest
Maybe we should update our code to not automatically add |
should be addressed in 4b2e121. The logic was written a while ago, nowdays most plugins have a |
Now, with the latest version of this PR, choosing |
it has been added in eslint-config-xo-typescript v0.52.0: https://github.com/xojs/eslint-config-xo-typescript/releases/tag/v0.52.0 |
b65f0ba
to
9583e59
Compare
as they do not officially support ts
e6654a9
to
434865c
Compare
friendly ping @mdjermanovic 😄 |
Sorry for the delay, I'll take a look soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I'll leave this open for a few days in case someone else wants to review it before merging.
as they do not officially support ts.
fixes #32