-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support workspaces #100
Closed
Closed
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
52d4de2
test: 💍 add test fixtures on pnpm workspace test
3125b96
test: 💍 add test case for finding pnpm workspace yaml
51606aa
feat: 🎸 implements findPnpmWorkspaceYaml function
44c2735
feat: 🎸 add pnpm workspace option when executing at root
f47dc3b
test: 💍 pnpm and pnpm workspace support test
cba9611
feat: 🎸 pnpm and yarn-legacy supoort
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ | ||
"name": "pnpm-workspace-project", | ||
"version": "1.0.0", | ||
"description": "", | ||
"main": "index.js", | ||
"scripts": { | ||
"test": "echo \"Error: no test specified\" && exit 1" | ||
}, | ||
"type": "module", | ||
"keywords": [], | ||
"author": "", | ||
"license": "ISC" | ||
} |
12 changes: 12 additions & 0 deletions
12
tests/fixtures/pnpm-workspace-project/packages/sub/package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"name": "sub", | ||
"version": "1.0.0", | ||
"description": "", | ||
"main": "index.js", | ||
"scripts": { | ||
"test": "echo \"Error: no test specified\" && exit 1" | ||
}, | ||
"keywords": [], | ||
"author": "", | ||
"license": "ISC" | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/** | ||
* @fileoverview tests for pnpm workspace install packages at root | ||
* @author Wataru Nishimura<[email protected]> | ||
*/ | ||
|
||
import { describe, it, expect, assert, afterEach } from "vitest"; | ||
import { fileURLToPath } from "node:url"; | ||
import { join } from "path"; | ||
import { findPnpmWorkspaceYaml, installSyncSaveDev } from "../lib/utils/npm-utils.js"; | ||
import sinon from "sinon"; | ||
import spawn from "cross-spawn"; | ||
|
||
const __filename = fileURLToPath(import.meta.url); // eslint-disable-line no-underscore-dangle -- commonjs convention | ||
|
||
describe("pnpm workspace install packages at root", () => { | ||
const pnpmWithWorkspaceDir = join(__filename, "../fixtures/pnpm-workspace-project"); | ||
|
||
afterEach(() => { | ||
sinon.verifyAndRestore(); | ||
}); | ||
|
||
it("find pnpm-workspace.yaml", () => { | ||
const pnpmWorkspaceYaml = findPnpmWorkspaceYaml(pnpmWithWorkspaceDir); | ||
|
||
expect(pnpmWorkspaceYaml).toBeTruthy(); | ||
}); | ||
|
||
it("should invoke pnpm to install a single desired package", () => { | ||
const stub = sinon.stub(spawn, "sync").returns({ stdout: 0 }); | ||
|
||
installSyncSaveDev("desired-package", "pnpm"); | ||
assert(stub.calledOnce); | ||
assert.strictEqual(stub.firstCall.args[0], "pnpm"); | ||
assert.deepStrictEqual(stub.firstCall.args[1], ["add", "-D", "desired-package"]); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can write this as a function(possible
isRootWorkspace()
), something like:it can be evalutated in the constructor, so you can just use it when you need it: