feat: typescript-eslint v8 has supported eslint v9 (#141)

refs: https://typescript-eslint.io/blog/announcing-typescript-eslint-v8
eslint · Aug 4, 2024 · f8d9c30 · f8d9c30
1 parent 4cf77fa
commit f8d9c30
Show file tree

Hide file tree

Showing 37 changed files with 37 additions and 80 deletions.
diff --git a/lib/config-generator.js b/lib/config-generator.js
@@ -4,7 +4,6 @@
  */
 import process from "node:process";
 import path from "node:path";
-import fs from "node:fs/promises";
 import { spawnSync } from "node:child_process";
 import { writeFile } from "node:fs/promises";
 import enquirer from "enquirer";
@@ -29,7 +28,7 @@ export class ConfigGenerator {
  this.packageJsonPath = options.packageJsonPath || findPackageJson(this.cwd);
  this.answers = options.answers || {};
  this.result = {
- devDependencies: ["eslint@9.x"],
+ devDependencies: ["eslint"],
  configFilename: "eslint.config.js",
  configContent: "",
  installFlags: ["-D"]
@@ -157,7 +156,6 @@ const compat = new FlatCompat({baseDirectory: __dirname, recommendedConfig: plug
  if (this.answers.language === "typescript") {
  extensions.push("ts");
  this.result.devDependencies.push("typescript-eslint");
- this.result.installFlags.push("--force"); // tseslint does not support eslint 9.x yet
  importContent += "import tseslint from \"typescript-eslint\";\n";
  exportContent += " ...tseslint.configs.recommended,\n";
  }
@@ -265,17 +263,6 @@ export default [\n${exportContent}];`;
  const configPath = path.join(this.cwd, this.result.configFilename);
 
  if (executeInstallation === true) {
-
- // removing `--force` when:
- // 1. yarn v2+ -- it does not support it.
- if (packageManager === "yarn") {
- const index = this.result.installFlags.indexOf("--force");
-
- if (index !== -1) {
- this.result.installFlags.splice(index, 1);
- }
- }
-
  log.info("☕️Installing...");
  installSyncSaveDev(this.result.devDependencies, packageManager, this.result.installFlags);
  await writeFile(configPath, this.result.configContent);
@@ -296,17 +283,5 @@ export default [\n${exportContent}];`;
  log.info(`Successfully created ${configPath} file.`);
  log.warn("You will need to install the dependencies yourself.");
  }
-
- if (this.result.installFlags.includes("--force")) {
- let message = "Note that some plugins currently do not support ESLint v9 yet.\nYou may need to use '--force' when installing";
-
- if (packageManager === "npm") {
- const pkg = JSON.parse(await fs.readFile(this.packageJsonPath, "utf8"));
-
- message += `, or add the following to your package.json: \n"overrides": { "eslint": "${pkg.devDependencies.eslint}" } `;
- }
-
- log.warn(message);
- }
  }
 }
diff --git a/tests/__snapshots__/problems-commonjs-none-javascript b/tests/__snapshots__/problems-commonjs-none-javascript
@@ -10,7 +10,7 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  ],

diff --git a/tests/__snapshots__/problems-commonjs-none-typescript b/tests/__snapshots__/problems-commonjs-none-typescript
@@ -13,13 +13,12 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  "typescript-eslint",
  ],
  "installFlags": [
  "-D",
- "--force",
  ],
 }
diff --git a/tests/__snapshots__/problems-commonjs-react-javascript b/tests/__snapshots__/problems-commonjs-react-javascript
@@ -13,7 +13,7 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  "eslint-plugin-react",

diff --git a/tests/__snapshots__/problems-commonjs-react-typescript b/tests/__snapshots__/problems-commonjs-react-typescript
@@ -15,14 +15,13 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  "typescript-eslint",
  "eslint-plugin-react",
  ],
  "installFlags": [
  "-D",
- "--force",
  ],
 }
diff --git a/tests/__snapshots__/problems-commonjs-vue-javascript b/tests/__snapshots__/problems-commonjs-vue-javascript
@@ -13,7 +13,7 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  "eslint-plugin-vue",

diff --git a/tests/__snapshots__/problems-commonjs-vue-typescript b/tests/__snapshots__/problems-commonjs-vue-typescript
@@ -16,14 +16,13 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  "typescript-eslint",
  "eslint-plugin-vue",
  ],
  "installFlags": [
  "-D",
- "--force",
  ],
 }
diff --git a/tests/__snapshots__/problems-esm-none-javascript b/tests/__snapshots__/problems-esm-none-javascript
@@ -9,7 +9,7 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  ],

diff --git a/tests/__snapshots__/problems-esm-none-typescript b/tests/__snapshots__/problems-esm-none-typescript
@@ -12,13 +12,12 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  "typescript-eslint",
  ],
  "installFlags": [
  "-D",
- "--force",
  ],
 }
diff --git a/tests/__snapshots__/problems-esm-react-javascript b/tests/__snapshots__/problems-esm-react-javascript
@@ -12,7 +12,7 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  "eslint-plugin-react",

diff --git a/tests/__snapshots__/problems-esm-react-typescript b/tests/__snapshots__/problems-esm-react-typescript
@@ -14,14 +14,13 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  "typescript-eslint",
  "eslint-plugin-react",
  ],
  "installFlags": [
  "-D",
- "--force",
  ],
 }
diff --git a/tests/__snapshots__/problems-esm-vue-javascript b/tests/__snapshots__/problems-esm-vue-javascript
@@ -12,7 +12,7 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  "eslint-plugin-vue",

diff --git a/tests/__snapshots__/problems-esm-vue-typescript b/tests/__snapshots__/problems-esm-vue-typescript
@@ -15,14 +15,13 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  "typescript-eslint",
  "eslint-plugin-vue",
  ],
  "installFlags": [
  "-D",
- "--force",
  ],
 }
diff --git a/tests/__snapshots__/problems-script-none-javascript b/tests/__snapshots__/problems-script-none-javascript
@@ -10,7 +10,7 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  ],

diff --git a/tests/__snapshots__/problems-script-none-typescript b/tests/__snapshots__/problems-script-none-typescript
@@ -13,13 +13,12 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  "typescript-eslint",
  ],
  "installFlags": [
  "-D",
- "--force",
  ],
 }
diff --git a/tests/__snapshots__/problems-script-react-javascript b/tests/__snapshots__/problems-script-react-javascript
@@ -13,7 +13,7 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  "eslint-plugin-react",

diff --git a/tests/__snapshots__/problems-script-react-typescript b/tests/__snapshots__/problems-script-react-typescript
@@ -15,14 +15,13 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  "typescript-eslint",
  "eslint-plugin-react",
  ],
  "installFlags": [
  "-D",
- "--force",
  ],
 }
diff --git a/tests/__snapshots__/problems-script-vue-javascript b/tests/__snapshots__/problems-script-vue-javascript
@@ -13,7 +13,7 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  "eslint-plugin-vue",

diff --git a/tests/__snapshots__/problems-script-vue-typescript b/tests/__snapshots__/problems-script-vue-typescript
@@ -16,14 +16,13 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "@eslint/js",
  "typescript-eslint",
  "eslint-plugin-vue",
  ],
  "installFlags": [
  "-D",
- "--force",
  ],
 }
diff --git a/tests/__snapshots__/syntax-commonjs-none-javascript b/tests/__snapshots__/syntax-commonjs-none-javascript
@@ -8,7 +8,7 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  ],
  "installFlags": [

diff --git a/tests/__snapshots__/syntax-commonjs-none-typescript b/tests/__snapshots__/syntax-commonjs-none-typescript
@@ -11,12 +11,11 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "typescript-eslint",
  ],
  "installFlags": [
  "-D",
- "--force",
  ],
 }
diff --git a/tests/__snapshots__/syntax-commonjs-react-javascript b/tests/__snapshots__/syntax-commonjs-react-javascript
@@ -11,7 +11,7 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "eslint-plugin-react",
  ],

diff --git a/tests/__snapshots__/syntax-commonjs-react-typescript b/tests/__snapshots__/syntax-commonjs-react-typescript
@@ -13,13 +13,12 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "typescript-eslint",
  "eslint-plugin-react",
  ],
  "installFlags": [
  "-D",
- "--force",
  ],
 }
diff --git a/tests/__snapshots__/syntax-commonjs-vue-javascript b/tests/__snapshots__/syntax-commonjs-vue-javascript
@@ -11,7 +11,7 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "eslint-plugin-vue",
  ],

diff --git a/tests/__snapshots__/syntax-commonjs-vue-typescript b/tests/__snapshots__/syntax-commonjs-vue-typescript
@@ -14,13 +14,12 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "typescript-eslint",
  "eslint-plugin-vue",
  ],
  "installFlags": [
  "-D",
- "--force",
  ],
 }
diff --git a/tests/__snapshots__/syntax-esm-none-javascript b/tests/__snapshots__/syntax-esm-none-javascript
@@ -7,7 +7,7 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  ],
  "installFlags": [

diff --git a/tests/__snapshots__/syntax-esm-none-typescript b/tests/__snapshots__/syntax-esm-none-typescript
@@ -10,12 +10,11 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "typescript-eslint",
  ],
  "installFlags": [
  "-D",
- "--force",
  ],
 }
diff --git a/tests/__snapshots__/syntax-esm-react-javascript b/tests/__snapshots__/syntax-esm-react-javascript
@@ -10,7 +10,7 @@ export default [
 ];",
  "configFilename": "eslint.config.js",
  "devDependencies": [
- "eslint@9.x",
+ "eslint",
  "globals",
  "eslint-plugin-react",
  ],