Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate domainpart against RFC #8

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

kamilwaz
Copy link

According to RFC-7622, the domainpart must comply to the following statement:

After any and all normalization, conversion, and mapping of code
points as well as encoding of the string as UTF-8, a domainpart MUST
NOT be zero octets in length and MUST NOT be more than 1023 octets in
length. (Naturally, the length limits of [RFC1034] apply, and
nothing in this document is to be interpreted as overriding those
more fundamental limits.)

In a short brief, it means that the domainpart cannot be an empty string.

@kamilwaz kamilwaz marked this pull request as ready for review November 21, 2022 08:17
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f040345) 83.90% compared to head (4ace714) 84.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   83.90%   84.09%   +0.18%     
==========================================
  Files           1        1              
  Lines          87       88       +1     
==========================================
+ Hits           73       74       +1     
  Misses         14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@NelsonVides NelsonVides merged commit 3d70277 into master Jan 11, 2024
3 checks passed
@NelsonVides NelsonVides deleted the validate-domainpart branch January 11, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants