Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades #11

Merged
merged 2 commits into from
Jun 2, 2024
Merged

Upgrades #11

merged 2 commits into from
Jun 2, 2024

Conversation

NelsonVides
Copy link
Collaborator

@NelsonVides NelsonVides commented Jun 2, 2024

A cosmetic PR incrementing code coverage and tweaking a few details in tests and documentation.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.00%. Comparing base (14c5242) to head (71053c1).

Files Patch % Lines
src/jid.erl 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #11       +/-   ##
===========================================
+ Coverage   85.10%   97.00%   +11.89%     
===========================================
  Files           1        1               
  Lines          94      100        +6     
===========================================
+ Hits           80       97       +17     
+ Misses         14        3       -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DenysGonchar DenysGonchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DenysGonchar DenysGonchar merged commit 398e31a into master Jun 2, 2024
3 checks passed
@DenysGonchar DenysGonchar deleted the upgrades branch June 2, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants