-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diff #1
Diff #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. Tests are a bit difficult to grasp, but I think adding a few comments would make them better (see comments). I would clean up the commit history a bit to make it cleaner and more descriptive.
test/hook_SUITE.erl
Outdated
{ok, GrSum} = file:consult(GrDir), | ||
#{sum => Sum, gr_sum => GrSum}. | ||
|
||
% ct_app/_build/test/logs/last/all_groups.summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these lines some leftovers? I don't see how they could be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, they are cat
s of these two files, to show the content, but I guess it is now in test cases, so could be removed.
ct_app/tests/test2_SUITE.erl
Outdated
@@ -0,0 +1,63 @@ | |||
-module(test2_SUITE). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to have at least some comments about the suites. Names like test_SUITE
, test2_SUITE
, test3_SUITE
are not helpful...
ct_app/tests/test_SUITE.erl
Outdated
failing_tc_2, | ||
failing_tc_3]. | ||
|
||
% init_per_suite(_Config) -> ?ERROR({error, init_per_suite}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some commented out lines like this one... maybe remove them?
ct_app/tests/test_SUITE.erl
Outdated
%% when they are no longer referenced | ||
[ {counter, atomics:new(1, [{signed, false}])} | Config ]. | ||
|
||
% end_per_suite(_Config) -> ?ERROR({error, end_per_suite}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well
Allow to specify any suite in run_test.sh
…sed_on_counter_and_always_ok_SUITE.erl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok 👍
It is already in master, there was some issues creating a first commit :) |
Added tests for ct hook.
Do not merge (just for diffing)