Cosmetics changes to improve readability, types, and upgrades #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #185 +/- ##
==========================================
- Coverage 75.19% 74.87% -0.33%
==========================================
Files 31 31
Lines 1165 1170 +5
==========================================
Hits 876 876
- Misses 289 294 +5 ☔ View full report in Codecov by Sentry. |
If the test has some deviation on the behaviour of clients according to their IDs, for example if every N clients the Nth will do extra work, then the distribution of clients across supervisors might not be uniform. For this, prefer hashing them.
| @@ -73,7 +73,7 @@ terminate(Scenario, State) -> | |||
| %% if scenario module exports both functions, `Scenario:start/2' is used. | |||
| %% | |||
| %% Runs on the user process and spans a `[amoc, scenario, user, _]' telemetry event. | |||
| -spec start(amoc:scenario(), user_id(), state()) -> any(). | |||
| -spec start(amoc:scenario(), user_id(), state()) -> term(). | |||
There was a problem hiding this comment.
any() highlights that returned value is ignored.
| -define(WORKER(I, Type), {I, {I, start_link, []}, permanent, 5000, Type, [I]}). | ||
| -define(SUP(I, Type), {I, {I, start_link, []}, permanent, infinity, Type, [I]}). | ||
| -define(WORKER(I), {I, {I, start_link, []}, permanent, 5000, worker, [I]}). | ||
| -define(SUP(I), {I, {I, start_link, []}, permanent, infinity, supervisor, [I]}). |
There was a problem hiding this comment.
yeah, this was a bit stupid :)
| @@ -139,14 +139,14 @@ terminate_all_children() -> | |||
| -spec get_sup_for_user_id(amoc_scenario:user_id()) -> pid(). | |||
| get_sup_for_user_id(Id) -> | |||
| #storage{sups = Supervisors, sups_count = SupCount} = persistent_term:get(?MODULE), | |||
| Index = Id rem SupCount + 1, | |||
| Index = erlang:phash2(Id, SupCount) + 1, | |||
There was a problem hiding this comment.
I'm not sure if phash makes a better distribution than a simple rem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.