Accept ranges of users in amoc_coordinator
#174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 75.08% 75.12% +0.04%
==========================================
Files 31 31
Lines 1160 1166 +6
==========================================
+ Hits 871 876 +5
- Misses 289 290 +1 ☔ View full report in Codecov by Sentry. |
NelsonVides
force-pushed
the
coordinator/ranges
branch
from
815f173
to
64eb304
Compare
NelsonVides
force-pushed
the
coordinator/ranges
branch
from
64eb304
to
e46b5e8
Compare
NelsonVides
force-pushed
the
coordinator/ranges
branch
2 times, most recently
from
912562b
to
3bacdf0
Compare
arcusfelis
reviewed
Feb 29, 2024
| @@ -125,6 +130,12 @@ safe_executions(Fun, Args) -> | |||
| _:_ -> ok | |||
| end. | |||
|
|
|||
| -spec calculate_n(amoc_coordinator:num_of_users()) -> all | pos_integer(). | |||
| calculate_n({Min, Diff}) -> | |||
There was a problem hiding this comment.
maybe could keep {Min, Max} format everywhere, not two formats
Sometimes we want to add some variance to the test and we want the coordinator
to choose groups of roughly N users instead of uniformly choosing all groups to
be of the exact same size. For this, we could give the coordinator a range of
the type {Min, Max} were every group will be chosen to have N in the interval
[Min, Max]. `rand:uniform/1` can be used to ensure that the distribution will be
pretty uniform, and in a sufficiently large scale, converge to N.
As a good to have, the coordinator could keep statistics of the distribution of
N in the interval.
NelsonVides
force-pushed
the
coordinator/ranges
branch
from
3bacdf0
to
67a0941
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we want to add some variance to the test and we want the coordinator to choose groups of roughly N users instead of uniformly choosing all groups to be of the exact same size. For this, we could give the coordinator a range of the type {Min, Max} were every group will be chosen to have N in the interval [Min, Max].
rand:uniform/1can be used to ensure that the distribution will be pretty uniform, and in a sufficiently large scale, converge to N.As a good to have, the coordinator could keep statistics of the distribution of N in the interval.