Configurable env parser #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelsonVides
reviewed
Aug 2, 2023
Comment on lines
+41
to
+45
| ?LOG_ERROR("cannot parse environment variable, using default value.~n" | ||
| " parsing error: '~p'~n" | ||
| " variable name: '$~s'~n" | ||
| " variable value: '~s'~n" | ||
| " default value: '~p'~n", |
There was a problem hiding this comment.
Now that I see these, can we use structured logging? Like, maps with keys and values. Maybe in a separate PR if there's plenty of these things anyway.
There was a problem hiding this comment.
I think it's worth to have a separate dedicated PR with all the logs reworked.
Comment on lines
+49
to
+51
| -type mfa(Arity) :: {module(), atom(), Arity}. | ||
| -type verification_method() :: none | one_of() | mfa(1) | verification_fun(). | ||
| -type update_method() :: read_only | none | mfa(2) | update_fun(). |
|
|
||
| -include_lib("kernel/include/logger.hrl"). | ||
|
|
||
| -define(DEFAULT_PARSER_MODULE, amoc_config_parser). | ||
|
|
||
| -callback(parse_value(string()) -> {ok, amoc_config:value()} | {error, any()}). |
There was a problem hiding this comment.
This is a perfect idea, but it only requires now documentation on how to do so when you want to add a different parser. So some md file in the guides directory, link it in the rebar config for hex like the others, etc.
There was a problem hiding this comment.
I think we need a separate dedicated PR with documentation update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
• Possibility to customise parsing (de-serialisation) logic for env variables.
• small improvements for
amoc_config_scenario:update_settings/1logic.• extension of the tests.