Apply review

src/throttle/amoc_throttle_controller.erl

@@ -85,6 +85,8 @@ stop(Name) ->
 telemetry_event(Name, Event) when Event =:= request; Event =:= execute ->
  raise_event(Name, Event).
 
+%% The purpose of this function is to ensure that there are no event duplicates if we are running in
+%% a single (non-distributed) node, as the throttle process will already raise this event.
 -spec raise_event_on_slave_node(name(), event()) -> ok.
 raise_event_on_slave_node(Name, Event) ->
  case amoc_cluster:master_node() =:= node() of

src/throttle/amoc_throttle_process.erl

@@ -37,8 +37,8 @@
  interval = 0 :: amoc_throttle:interval(), %%ms
  delay_between_executions = 0 :: non_neg_integer(), %%ms
  tref :: timer:tref() | undefined,
- schedule = [] :: [amoc_throttle_runner:runner()],
- schedule_reversed = [] :: [amoc_throttle_runner:runner()]}).
+ schedule = [] :: [AmocThrottleRunnerProcess :: pid()],
+ schedule_reversed = [] :: [AmocThrottleRunnerProcess :: pid()]}).
 
 -type state() :: #state{}.
 %%------------------------------------------------------------------------------
@@ -53,7 +53,7 @@ start_link(Name, Interval, Rate) ->
 stop(Pid) ->
  gen_server:cast(Pid, stop_process).
 
--spec run(pid(), amoc_throttle_runner:runner()) -> ok.
+-spec run(pid(), pid()) -> ok.
 run(Pid, RunnerPid) ->
  gen_server:cast(Pid, {schedule, RunnerPid}).
 

src/throttle/amoc_throttle_runner.erl

@@ -10,14 +10,10 @@
 -export([async_runner/3]).
 
 -type action() :: wait | {pid(), term()} | fun(() -> any()).
--type runner() :: pid().
--export_type([runner/0]).
 
--spec run(runner()) -> reference().
+-spec run(pid()) -> term().
 run(RunnerPid) ->
- Ref = erlang:monitor(process, RunnerPid),
- RunnerPid ! '$scheduled',
- Ref.
+ RunnerPid ! '$scheduled'.
 
 -spec throttle(amoc_throttle:name(), action()) -> ok | {error, any()}.
 throttle(Name, Action) ->
@@ -30,7 +26,7 @@ throttle(Name, Action) ->
  Error
  end.
 
--spec maybe_wait(action(), runner()) -> ok.
+-spec maybe_wait(action(), pid()) -> ok.
 maybe_wait(wait, RunnerPid) ->
  receive
  {'EXIT', RunnerPid, Reason} ->