Fix [amoc, users, size] metric #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was reading an ets table that is in fact an implementation detail.
Now it uses the correctly exposed callback to read.
```
$ rebar3 shell
===> Verifying dependencies...
===> Analyzing applications...
===> Compiling amoc_arsenal
Erlang/OTP 27 [erts-15.0.1] [source] [64-bit] [smp:12:12] [ds:12:12:10] [async-threads:1] [jit]
Eshell V15.0.1 (press Ctrl+G to abort, type help(). for help)
=WARNING REPORT==== 29-Aug-2024::17:38:43.547597 ===
Reporter=exometer_report_graphite not_enabled
=WARNING REPORT==== 29-Aug-2024::17:38:43.547645 ===
Reporter=exometer_report_graphite not_enabled
=WARNING REPORT==== 29-Aug-2024::17:38:43.547662 ===
Reporter=exometer_report_graphite not_enabled
===> Booted compiler
===> Booted telemetry
===> Booted amoc
===> Booted exometer_core
===> Booted exometer_report_graphite
===> Booted jsx
===> Booted rfc3339
===> Booted jesse
===> Booted cowlib
===> Booted ranch
===> Booted cowboy
===> Booted amoc_rest
===> Booted syntax_tools
===> Booted edoc
===> Booted xmerl
===> Booted docsh
===> Booted amoc_arsenal
===> Booted runtime_tools
1> exometer:get_value([amoc, users]).
{ok,[{size,0}]}
```
NelsonVides
force-pushed
the
fix_users_size_metric
branch
from
e656952
to
82d8854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reading an ets table that is in fact an implementation detail.
Now it uses the correctly exposed callback to read.