Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(max): bad password return GENERAL_ERROR instead CHANGE_PASSWORD #847

Merged
merged 4 commits into from
Apr 1, 2024
Merged

fix(max): bad password return GENERAL_ERROR instead CHANGE_PASSWORD #847

merged 4 commits into from
Apr 1, 2024

Conversation

gczobel
Copy link
Contributor

@gczobel gczobel commented Mar 30, 2024

fix #846

baruchiro
baruchiro approved these changes Mar 31, 2024
View reviewed changes
Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

You have a lint issue, if you want me to continue from here just say it.

@gczobel
Copy link
Contributor Author

gczobel commented Mar 31, 2024

Thank you.

You have a lint issue, if you want me to continue from here just say it.

No need. Fixed!

@baruchiro baruchiro changed the title fix: bad password return GENERAL_ERROR instead CHANGE_PASSWORD fix(max): bad password return GENERAL_ERROR instead CHANGE_PASSWORD Apr 1, 2024
@baruchiro baruchiro merged commit c873557 into eshaham:master Apr 1, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

🎉 This PR is included in version 4.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baruchiro baruchiro baruchiro approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Max] Issue: bad password return GENERAL_ERROR instead CHANGE_PASSWORD
2 participants
@gczobel @baruchiro