-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multiple accounts on beinleumi base #842
feat: multiple accounts on beinleumi base #842
Conversation
…ase class ,fetchAccounts method.
Hi @nissant, Thank you for your contribution! I'm reviewing your suggestion. Meanwhile, if you think you can help us more, I'm inviting you to register as a Code Owner: #830 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Usually, when you suggest a change, we ask for more contributors with the same bank account to test your change, because sometimes the website acts differently for different users (depending on user config and account...)
For this case, we need someone to test your change with Beinleumi or Massad, but no one was registered on #830
…ub.com/nissant/israeli-bank-scrapers into ntagar-beinleumi-multi-account-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@baruchiro Looks like all the checks have passed and PR is ready to merge, can you please allow it? |
Thank you for the reminder |
🎉 This PR is included in version 4.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Changes: