Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiple accounts on beinleumi base #842

Merged

Conversation

nisan-tagar
Copy link
Contributor

@nisan-tagar nisan-tagar commented Mar 23, 2024

Changes:

  • Add graceful support for scrapping multiple accounts on beinleumi base -> fetchAccounts method. This is a 3 year old TODO item in the existing code base comments :)
  • I have a FIBI account and was able to test the scrapper successfully.

@baruchiro
Copy link
Collaborator

Hi @nissant, Thank you for your contribution!

I'm reviewing your suggestion. Meanwhile, if you think you can help us more, I'm inviting you to register as a Code Owner: #830

@baruchiro baruchiro self-requested a review March 26, 2024 07:54
Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Usually, when you suggest a change, we ask for more contributors with the same bank account to test your change, because sometimes the website acts differently for different users (depending on user config and account...)

For this case, we need someone to test your change with Beinleumi or Massad, but no one was registered on #830

src/scrapers/base-beinleumi-group.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@baruchiro baruchiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baruchiro baruchiro changed the title Add graceful support for scrapping multiple accounts on beinleumi base feat: multiple accounts on beinleumi base Apr 1, 2024
@nisan-tagar
Copy link
Contributor Author

@baruchiro Looks like all the checks have passed and PR is ready to merge, can you please allow it?

@baruchiro
Copy link
Collaborator

Thank you for the reminder

@baruchiro baruchiro merged commit 3a605dc into eshaham:master Apr 15, 2024
6 checks passed
Copy link

🎉 This PR is included in version 4.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants