Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/loading #69

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Feat/loading #69

merged 5 commits into from
Dec 1, 2023

Conversation

judy0ye
Copy link
Contributor

@judy0ye judy0ye commented Nov 30, 2023 •
edited
Loading

What I did:

  • Add loading states to all components that render images and network requests

Did this break anything?

  • No
  • Yes

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactor(DRY-ing up/ reorganizing code, etc.)
  • Super small fix (Corrected a typo, removed a comment, etc.)
  • Skip all the other stuff and briefly explain the fix.

Checklist:

  • If this code needs to be tested, all tests are passing
  • The code runs locally
  • There are comments where clarification/ organization is needed
  • The code is DRY. If it's not, I tried my best
  • I reviewed my code before pushing

Notes:

Contributors to this pull request:

@vercel Vercel
Copy link

vercel bot commented Nov 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
escapelink-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 2:33am

@judy0ye judy0ye added enhancement New feature or request Front End labels Nov 30, 2023
kcockett
kcockett approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@kcockett kcockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of the work

@kcockett kcockett merged commit 60ebaec into main Dec 1, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcockett kcockett kcockett approved these changes

@Averyberryman Averyberryman Awaiting requested review from Averyberryman

@MWoodshop MWoodshop Awaiting requested review from MWoodshop

@dani-wilson dani-wilson Awaiting requested review from dani-wilson

Assignees
No one assigned
Labels
enhancement New feature or request Front End
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@judy0ye @kcockett