Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to names #48

Merged
merged 4 commits into from
Oct 20, 2023
Merged

Change to names #48

merged 4 commits into from
Oct 20, 2023

Conversation

MWoodshop
Copy link
Contributor

What I did: Fixes the URL so it's now the dynamic roomName then the backend URL. Also sends room_name to BE instead of room_id.

Did this break anything?

  • No
  • Yes

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactor(DRY-ing up/ reorganizing code, etc.)
  • Super small fix (Corrected a typo, removed a comment, etc.)
  • Skip all the other stuff and briefly explain the fix.

Checklist:

  • If this code needs to be tested, all tests are passing
  • The code runs locally
  • There are comments where clarification/ organization is needed
  • The code is DRY. If it's not, I tried my best
  • I reviewed my code before pushing

Notes:

Contributors to this pull request:

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
escapelink-fe ✅ Ready (Inspect) Visit Preview Oct 20, 2023 5:20pm

@Averyberryman Averyberryman merged commit 9583d6e into main Oct 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants