Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cypress test for landing page #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add cypress test for landing page #40

wants to merge 1 commit into from

Conversation

judy0ye
Copy link
Contributor

@judy0ye judy0ye commented Oct 19, 2023

What I did:

Did this break anything?

  • Add cypress test for landing page

  • No

  • Yes

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactor(DRY-ing up/ reorganizing code, etc.)
  • Super small fix (Corrected a typo, removed a comment, etc.)
  • Skip all the other stuff and briefly explain: added testing

Checklist:

  • If this code needs to be tested, all tests are passing
  • The code runs locally
  • There are comments where clarification/ organization is needed
  • The code is DRY. If it's not, I tried my best
  • I reviewed my code before pushing

Notes:

Contributors to this pull request:

@judy0ye judy0ye requested a review from Averyberryman October 19, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani-wilson dani-wilson dani-wilson approved these changes

@Averyberryman Averyberryman Awaiting requested review from Averyberryman

Assignees
No one assigned
Labels
Front End
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@judy0ye @dani-wilson