fix: non integer image position #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Adam-Alj, thanks for the pull request 🚀 |
fix: maintain center position
Adam-Alj
force-pushed
the
fiximagepos
branch
from
50161bc to
9530f4f
Compare
|
Hi @erwanvivien , sorry this took so long, life gets in the way. Squashed those commits, lmk if you need anything else from my end, thanks! |
erwanvivien
approved these changes
Nov 26, 2024
|
@erwanvivien thanks for merging! Could you please publish a new version with this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When embedding an image, it is currently possible to have the image placed in a non-integer position.
The result is that QR "bits" are partially covered.
This can be replicated by modifying the existing
embedexample by callingimage_size(4f64)on theImageBuilder.Here is the (erroneous) output before this change:
Here is the (correct) output with this change:
