Skip to content

Commit

Permalink
[EDR Workflows][Osquery] Increase initial page load timeout, unskip t…
Browse files Browse the repository at this point in the history
…ests (elastic#190231)

This test failed in the `before` block because the page did not load
within the expected default of 60 seconds. Since Serverless (where the
test failed) can be slower at times, I've increased the timeout to 90
seconds, as we have no control over the app's loading speed.

![Screenshot 2024-08-09 at 13 55
24](https://github.com/user-attachments/assets/be00dcfa-774f-4f36-a4f3-fdac4e838596)
  • Loading branch information
szwarckonrad authored Aug 9, 2024
1 parent 986001c commit eaf674d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ import {
import { closeModalIfVisible, closeToastIfVisible } from '../../tasks/integrations';
import { RESULTS_TABLE, RESULTS_TABLE_BUTTON } from '../../screens/live_query';

// Failing: See https://github.com/elastic/kibana/issues/173451
describe.skip(
describe(
'Alert Event Details',
{
tags: ['@ess', '@serverless'],
Expand Down
3 changes: 1 addition & 2 deletions x-pack/plugins/osquery/cypress/e2e/all/ecs_mappings.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ import {
} from '../../tasks/live_query';
import { ServerlessRoleName } from '../../support/roles';

// Failing: See https://github.com/elastic/kibana/issues/182467
describe.skip('EcsMapping', { tags: ['@ess', '@serverless'] }, () => {
describe('EcsMapping', { tags: ['@ess', '@serverless'] }, () => {
before(() => {
initializeDataViews();
});
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugins/osquery/cypress/tasks/login.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export const initializeDataViews = () => {
onBeforeLoad: (win) => disableNewFeaturesTours(win),
});
cy.getBySel('globalLoadingIndicator').should('exist');
cy.getBySel('globalLoadingIndicator').should('not.exist');
// In serverless the app sometimes takes a long time to load with this check causing flakiness.
cy.getBySel('globalLoadingIndicator', { timeout: 1.5 * 60 * 1000 }).should('not.exist');
cy.getBySel('manage-alert-detection-rules').should('exist');
};

0 comments on commit eaf674d

Please sign in to comment.