Skip to content

Commit

Permalink
[Lens] Cleanups the veil flag from the ExpressionWrapper (elastic#176363
Browse files Browse the repository at this point in the history
)

## Summary

Cleanups the unused shouldUseSizeTransitionVeil from the
ExpressionWrapper. This true default value can cause bugs in
embeddables.
  • Loading branch information
stratoula authored Feb 7, 2024
1 parent 23b4b53 commit e9e7304
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions x-pack/plugins/lens/public/embeddable/expression_wrapper.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ export interface ExpressionWrapperProps {
executionContext?: KibanaExecutionContext;
lensInspector: LensInspector;
noPadding?: boolean;
shouldUseSizeTransitionVeil?: boolean;
abortController?: AbortController;
}

Expand All @@ -73,7 +72,6 @@ export function ExpressionWrapper({
executionContext,
lensInspector,
noPadding,
shouldUseSizeTransitionVeil,
abortController,
}: ExpressionWrapperProps) {
if (!expression) return null;
Expand All @@ -97,7 +95,6 @@ export function ExpressionWrapper({
syncCursor={syncCursor}
executionContext={executionContext}
abortController={abortController}
shouldUseSizeTransitionVeil={shouldUseSizeTransitionVeil ?? true}
renderError={(errorMessage, error) => {
const messages = getOriginalRequestErrorMessages(error || null);
addUserMessages(messages);
Expand Down

0 comments on commit e9e7304

Please sign in to comment.