Skip to content

Commit

Permalink
Add new RCF for GCS and ABS in native connector (elastic#174512)
Browse files Browse the repository at this point in the history
Summary
[Related to
https://github.com/elastic/connectors/issues/1819](https://github.com/elastic/connectors/issues/1831)

1. Add new config parameter in ABS Connector `containers`
2. Add new config parameter in GCS Connector `buckets`
3. please add label 8.13 for this PR

Checklist
Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

For maintainers
 

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
  • Loading branch information
akanshi-elastic and kibanamachine authored Jan 17, 2024
1 parent f72c7dc commit d5b837d
Showing 1 changed file with 46 additions and 6 deletions.
52 changes: 46 additions & 6 deletions packages/kbn-search-connectors/types/native_connectors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -157,13 +157,33 @@ export const NATIVE_CONNECTOR_DEFINITIONS: Record<string, NativeConnector | unde
validations: [],
value: '',
},
containers: {
default_value: null,
depends_on: [],
display: DisplayType.TEXTAREA,
label: i18n.translate(
'searchConnectors.nativeConnectors.azureBlobStorage.containerNameLabel',
{
defaultMessage: 'List of containers',
}
),
options: [],
order: 4,
required: true,
sensitive: false,
tooltip: null,
type: FieldType.LIST,
ui_restrictions: [],
validations: [],
value: '',
},
retry_count: {
default_value: 3,
depends_on: [],
display: DisplayType.NUMERIC,
label: RETRIES_PER_REQUEST_LABEL,
options: [],
order: 4,
order: 5,
required: false,
sensitive: false,
tooltip: null,
Expand All @@ -178,7 +198,7 @@ export const NATIVE_CONNECTOR_DEFINITIONS: Record<string, NativeConnector | unde
display: DisplayType.NUMERIC,
label: MAX_CONCURRENT_DOWNLOADS_LABEL,
options: [],
order: 5,
order: 6,
required: false,
sensitive: false,
tooltip: null,
Expand All @@ -198,7 +218,7 @@ export const NATIVE_CONNECTOR_DEFINITIONS: Record<string, NativeConnector | unde
display: DisplayType.TOGGLE,
label: USE_TEXT_EXTRACTION_SERVICE_LABEL,
options: [],
order: 6,
order: 7,
required: true,
sensitive: false,
tooltip: USE_TEXT_EXTRACTION_SERVICE_TOOLTIP,
Expand Down Expand Up @@ -783,6 +803,26 @@ export const NATIVE_CONNECTOR_DEFINITIONS: Record<string, NativeConnector | unde
google_cloud_storage: {
features: {},
configuration: {
buckets: {
default_value: null,
depends_on: [],
display: DisplayType.TEXTAREA,
label: i18n.translate(
'searchConnectors.nativeConnectors.googleCloudStorage.bucketNameLabel',
{
defaultMessage: 'List of buckets',
}
),
options: [],
order: 1,
required: true,
sensitive: false,
tooltip: null,
type: FieldType.LIST,
ui_restrictions: [],
validations: [],
value: '',
},
service_account_credentials: {
default_value: null,
depends_on: [],
Expand All @@ -791,7 +831,7 @@ export const NATIVE_CONNECTOR_DEFINITIONS: Record<string, NativeConnector | unde
defaultMessage: 'Google Cloud service account JSON',
}),
options: [],
order: 1,
order: 2,
required: true,
sensitive: true,
tooltip: null,
Expand All @@ -808,7 +848,7 @@ export const NATIVE_CONNECTOR_DEFINITIONS: Record<string, NativeConnector | unde
defaultMessage: 'Maximum retries for failed requests',
}),
options: [],
order: 2,
order: 3,
required: false,
sensitive: false,
tooltip: null,
Expand All @@ -823,7 +863,7 @@ export const NATIVE_CONNECTOR_DEFINITIONS: Record<string, NativeConnector | unde
display: DisplayType.TOGGLE,
label: USE_TEXT_EXTRACTION_SERVICE_LABEL,
options: [],
order: 3,
order: 4,
required: true,
sensitive: false,
tooltip: USE_TEXT_EXTRACTION_SERVICE_TOOLTIP,
Expand Down

0 comments on commit d5b837d

Please sign in to comment.