Update to PHP 8.3, Remove libiconv patch #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erseco
commented
Dec 21, 2023
| @@ -1,5 +1,5 @@ | |||
| ARG ARCH= | |||
| FROM ${ARCH}erseco/alpine-php-webserver:latest | |||
| FROM ${ARCH}erseco/alpine-php-webserver:php83 | |||
There was a problem hiding this comment.
Suggested change
| FROM ${ARCH}erseco/alpine-php-webserver:php83 | |
| FROM ${ARCH}erseco/alpine-php-webserver:latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've submitted this pull request to address critical updates required for the upcoming Moodle release. However, it's important to note that we need to verify compatibility with Moodle, particularly with the anticipated Moodle 4.4 release which is expected to officially support PHP 8.3. Here are the key changes in this PR:
Update Base Image: The base image
alpine-php-webserverhas been updated to utilize the Alpine PHP 8.3 package. This update ensures compatibility with the latest PHP standards and improves overall stability and performance.Removal of Libiconv Patch: With the update to PHP 8.3, the previously necessary
libiconvpatch is now redundant. Its removal is part of this update, streamlining the image and reducing unnecessary complexity.Preparation for Moodle Release: These changes are in anticipation of the next Moodle release. They ensure that our environment remains in sync with the latest Moodle requirements, providing an optimized experience for all users.
For detailed discussions and the background of these changes, please refer to Issue #26 on our tracker.
I believe these updates are critical for maintaining the reliability and efficiency of our Moodle deployments. Your review and feedback on this PR would be greatly appreciated.
Best regards,
Ernesto