fix: normalizePath tilde expansion on Windows (#656)

normalizePath sometimes gets backslash paths as input. In such case it will not be able to act on the ~/ prefix, since it will be \~ instead. FromSlash will provide the correct variant. Co-authored-by: Lander Visterin <[email protected]>
errata-ai · Jul 4, 2023 · 27fe2f6 · 27fe2f6
1 parent 545983e
commit 27fe2f6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/core/util.go b/internal/core/util.go
@@ -233,7 +233,7 @@ func normalizePath(path string) string {
  }
  if path == "~" {
  return homedir
- } else if strings.HasPrefix(path, "~/") {
+ } else if strings.HasPrefix(path, filepath.FromSlash("~/")) {
  path = filepath.Join(homedir, path[2:])
  }
  return path

diff --git a/internal/core/util_test.go b/internal/core/util_test.go
@@ -55,7 +55,7 @@ func TestNormalizePath(t *testing.T) {
  t.Log("os.UserHomeDir failed, will not proceed with tests")
  return
  }
- stylesPathInput := "~/.vale"
+ stylesPathInput := filepath.FromSlash("~/.vale")
  expectedOutput := filepath.Join(homedir, ".vale")
  result := normalizePath(stylesPathInput)
  if result != expectedOutput {