Refactor group to use gen_statem #8765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garazdawi
added
team:VM
garazdawi
changed the title
garazdawi
changed the title
CT Test Results 4 files 172 suites 1h 47m 44s ⏱️ For more details on these failures, see this check. Results for commit bdc79da. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
force-pushed
the
lukas/kernel/refactor-group-gen_statem
branch
from
bb979e4
to
bdc79da
Compare
frazze-jobb
approved these changes
Sep 4, 2024
We should only use send_stdin when send_tty does not work, for example with invalid unicode.
garazdawi
force-pushed
the
lukas/kernel/refactor-group-gen_statem
branch
from
bdc79da
to
0169a29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.