Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rand.erl Documentation bug: exs928ss does not work, perhaps ex… #8745

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

Koistinen
Copy link
Contributor

My first attempt at contributing.
I tried the code in the documentation and it did not work with Erlang/OTP 24 [erts-12.2.1] [source] [64-bit] [smp:16:16] [ds:16:16:10] [async-threads:1] [jit].
Tested it with Erlang/OTP 27 and that did not work either.
Changing it at least ran and I got random numbers but not starting with a fixed PRNG.
(Got different random numbers each time despite calling seed with an algorithm and a seed.)

@CLAassistant
Copy link

CLAassistant commented Aug 25, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Aug 25, 2024

CT Test Results

    2 files     95 suites   36m 26s ⏱️
2 147 tests 2 099 ✅ 48 💤 0 ❌
2 456 runs  2 406 ✅ 50 💤 0 ❌

Results for commit 8af1b0e.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@RaimoNiskanen
Copy link
Contributor

RaimoNiskanen commented Aug 26, 2024

@Koistinen The change looks perfectly right, and I wouldn't mind if you rebased this to 'maint' so it can be fixed in OTP 27.1.

And it works for me:

Erlang/OTP 27 [erts-15.0.1] [source-50cc3be786] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit:ns]

Eshell V15.0.1 (press Ctrl+G to abort, type help(). for help)
1> rand:seed(exro928ss, {123, 123534, 345345}), ok.
ok
2> rand:uniform().
0.9605668553593557
3> rand:uniform().
0.9614947236922335
4> rand:uniform().
0.24859899775400773
5> rand:seed(exro928ss, {123, 123534, 345345}), ok.
ok
6> rand:uniform().
0.9605668553593557
7> rand:uniform().
0.9614947236922335
8> rand:uniform().
0.24859899775400773

@rickard-green rickard-green added the team:PS Assigned to OTP team PS label Aug 26, 2024
@IngelaAndin IngelaAndin added the testing currently being tested, tag is used by OTP internal CI label Aug 27, 2024
@RaimoNiskanen RaimoNiskanen removed the testing currently being tested, tag is used by OTP internal CI label Aug 30, 2024
@RaimoNiskanen RaimoNiskanen merged commit 38b5f87 into erlang:master Aug 30, 2024
3 checks passed
@RaimoNiskanen
Copy link
Contributor

I merged the fix into 'maint' and 'master'.

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation rand module example fails because of misspelled algorithm name
5 participants