Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add shasum to check has on OSX #8707

Conversation

kikofernandez
Copy link
Contributor

adds the dependency shasum to check the checksum of ex_doc.
this was necessary because OSX does not come with sha256sum nor sha1sum.

Closes #8656

adds the dependency `shasum` to check the checksum of ex_doc.
this was necessary because OSX does not come with sha256sum nor sha1sum.
@kikofernandez kikofernandez requested a review from garazdawi August 9, 2024 11:43
@kikofernandez kikofernandez self-assigned this Aug 9, 2024
@kikofernandez kikofernandez changed the base branch from master to maint August 9, 2024 11:43
@kikofernandez kikofernandez added the team:VM Assigned to OTP team VM label Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

CT Test Results

  1 files   11 suites   4m 23s ⏱️
 93 tests  91 ✅ 2 💤 0 ❌
109 runs  107 ✅ 2 💤 0 ❌

Results for commit 29cfafa.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

Copy link
Contributor

@garazdawi garazdawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kikofernandez kikofernandez added the testing currently being tested, tag is used by OTP internal CI label Aug 12, 2024
@kikofernandez kikofernandez merged commit 5452810 into erlang:maint Aug 16, 2024
17 checks passed
@kikofernandez kikofernandez deleted the kiko/doc/add-shasum-to-build-doc-on-osx/GH-8656 branch August 16, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR: download_ex_doc failed.
2 participants