Refactor type annotation handling for clarity #8586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In erlang#8564, Frej Drejhammar noticed that the following comment was misleading: %% One or more arguments have been simplified to literal values. It turns out that the entire clause in which the comment is located is not needed. Removing the `arg_types` annotation is unnecessary, since it will be added back in the next iteration of the `beam_ssa_type` pass. This commit removes the unnecessary clause, as well as strengthening and explaining the invariants maintained by `opt_anno_types/2`.
bjorng
added
team:VM
CT Test Results 2 files 324 suites 9m 56s ⏱️ Results for commit bb29ba3. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8564, Frej Drejhammar noticed that the following comment was misleading:
It turns out that the entire clause in which the comment is located is not needed. Removing the
arg_typesannotation is unnecessary, since it will be added back in the next iteration of thebeam_ssa_typepass.This commit removes the unnecessary clause, as well as strengthening and explaining the invariants maintained by
opt_anno_types/2.