Describe key combinations consistently #8577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Control always written as Ctrl. Letter keys always uppercase. Modifiers (Shift, Alt, Ctrl) always titlecase.
Ensure that the UI is consistent (help messages, menus, etc.) and that it's easy to grep in the code. Note that the documentation has a different style and uses `-` to describe key combinations.
CT Test Results 11 files 400 suites 3h 32m 54s ⏱️ For more details on these failures, see this check. Results for commit ea381d0. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
jhogberg
added
the
testing
|
Merged! Thanks for the PR, and sorry about the wait -- I totally forgot about this :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the UI is consistent (help messages, menus, etc.) and that
it's easy to grep in the code for key combination mentions.
+to write key combinations in source code and UI-instead.