Fix up the built-in help text in the shell #8573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort the entries for readability. Document the exit/0 builtin. Move the code for the builtins help to the shell module itself to make it easier to keep it in sync. Move text for hcb() and ht() functions to the c module since they are not shell builtins.
CT Test Results 2 files 95 suites 35m 26s ⏱️ For more details on these failures, see this check. Results for commit 83b8f12. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
frazze-jobb
reviewed
Jul 4, 2024
lib/stdlib/src/shell.erl
Outdated
| @@ -1327,6 +1370,7 @@ local_func(tf, [{atom,_,A}], Bs, _Shell, _RT, FT, _Lf, _Ef) -> | |||
| local_func(tf, [_], _Bs, _Shell, _RT, _FT, _Lf, _Ef) -> | |||
| erlang:raise(error, function_clause, [{shell,tf,1}]); | |||
| local_func(rd, [{string, _, TypeDef}], Bs, _Shell, RT, FT, _Lf, _Ef) -> | |||
| %% currently not documented in help() | |||
There was a problem hiding this comment.
this is one that should only be used internally, so are td and fd
frazze-jobb
added
the
testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort the entries for readability. Document the exit/0 builtin. Move the code for the builtins help to the shell module itself to make it easier to keep it in sync. Move text for hcb() and ht() functions to the c module since they are not shell builtins.