Fix errors for gcc 14 #8553
Merged
Fix errors for gcc 14 #8553
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 3 files 143 suites 49m 46s ⏱️ For more details on these failures, see this check. Results for commit f5ac901. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
jhogberg
added
testing
jhogberg
requested changes
Jun 11, 2024
With GCC 14 series, the following error exists:
fp_drv.c: In function 'control':
fp_drv.c:126:48: error: passing argument 2 of 'erl_drv_thread_join' from
incompatible pointer type [-Wincompatible-pointer-types]
126 | else if (0 != erl_drv_thread_join(tid, &res_str))
| ^~~~~~~~
| |
| char **
In file included from fp_drv.c:43:
/build/tmp/work/core2-64-poky-linux/erlang/27.0/git/erts/emulator/beam/erl_driver.h:487:50:
note: expected 'void **' but argument is of type 'char **'
487 | EXTERN int erl_drv_thread_join(ErlDrvTid, void **respp);
| ~~~~~~~^~~~~
With GCC 14 series, the following error exists:
dead_port.c:43:26: error: return type defaults to 'int' [-Wimplicit-int]
43 | #define MAIN(argc, argv) main(argc, argv)
| ^~~~
dead_port.c:50:1: note: in expansion of macro 'MAIN'
50 | MAIN(argc, argv)
| ^~~~
With GCC 14 series the following error exists:
unlink_signal_drv.c: In function 'start':
unlink_signal_drv.c:77:17: error: assignment to 'ErlDrvData' {aka
'struct _erl_drv_data *'} from incompatible pointer type 'ErlDrvPort'
{aka 'struct _erl_drv_port *'} [-Wincompatible-pointer-types]
77 | state->port = port;
| ^
unlink_signal_drv.c: In function 'output':
unlink_signal_drv.c:86:27: error: passing argument 1 of
'driver_set_timer' from incompatible pointer type
[-Wincompatible-pointer-types]
86 | driver_set_timer(state->port, 2);
| ~~~~~^~~~~~
| |
| ErlDrvData {aka struct _erl_drv_data
*}
joaohf
force-pushed
the
fix-errors-for-gcc-14
branch
from
df79492 to
f5ac901
Compare
jhogberg
added
the
testing
|
Merged, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When building Erlang/OTP 27 with GCC 14.1.0, I got some compilations errors.
Thanks.