Fix heap allocation for matching out short bitstrings #7581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorng
added
team:VM
CT Test Results 3 files 133 suites 48m 37s ⏱️ Results for commit a9ed6ec. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
sverker
reviewed
Aug 23, 2023
sverker
approved these changes
Aug 23, 2023
The runtime system could underestimate the amount of heap space needed for matching out short bitstrings with a size not divisble by 8. That could lead to the runtime system terminating with an "Overrun heap and stack" error. Fixes erlang#7292
bjorng
force-pushed
the
bjorn/jit/small-bitstrings/GH-7292/OTP-18733
branch
from
c2f575e
to
a9ed6ec
Compare
bjorng
added a commit
to bjorng/otp
that referenced
this pull request
Aug 30, 2023
Normally, all BEAM files created by OTP 25 and later have a "Type" chunk that contains type information. `beam_lib:strip/1` will not discard the "Type" chunk, but build/release scripts that do their own custom stripping could accidentally delete the chunk. Make sure to test that loading and executing BEAM files without type information works. Since there was an overrun-heap-and-stack bug (reported in erlang#7292, fixed in erlang#7581) when using the bit syntax, the bit syntax test suites seems to appropriate to clone to new BEAM files without types.
This was referenced Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime system could underestimate the amount of heap space needed for matching out short bitstrings with a size not divisble by 8. That could lead to the runtime system terminating with an "Overrun heap and stack" error.
Fixes #7292