Zip generator for comprehensions #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Oct 10, 2024
eeps/eep-0073.md
Outdated
|
|
||
| When a zip generator crashes because the containing generators are of | ||
| different lengths, the error message is a tuple, where the first element | ||
| is the atom `bad_generators`, and the second element is a tuple that contains |
There was a problem hiding this comment.
Nitpick: I believe all of the errors raised by Erlang do not have a _ after bad. You have badarg, badfun, badkey, badmap, etc. I would probably keep it consistent.
There was a problem hiding this comment.
That's my bad. I should write the user-facing error message, not just the internal one. Some errors in erl_error.erl use _ though, like bad_generator, but it's internal. Thanks for pointing it out :)
There was a problem hiding this comment.
Ah, if we already have bad_generator, then bad_generators make the most sense. Thank you!
bjorng
reviewed
Oct 10, 2024
eeps/eep-0073.md
Outdated
| then becomes a special case of comprehension where only zip generators are | ||
| used. | ||
|
|
||
| In summary, zip generator removes the user's need to call the zip function |
There was a problem hiding this comment.
Suggested change
| In summary, zip generator removes the user's need to call the zip function | |
| In summary, zip generators removes the user's need to call the zip function |
| any number of the 3 kinds of generators above. Zip generators can be used | ||
| in list, binary, or map comprehensions in the same way. | ||
|
|
||
| For example, if the two generators in the above example is combined together |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This EEP proposes the addition of zip generators with a syntax of
&&forcomprehensions in Erlang. The idea and syntax of zip generators (comprehension
multigenerators) was first brought up by EEP-19. Even if the syntax and
usages of zip generators proposed by this EEP is mostly the same with EEP-19,
the comprehension language of Erlang has undergone many changes since EEP-19
was accepted. With an implementation that is compatible with all existing
comprehensions, this EEP defines the behavior of zip generators with more
clarification on the compiler's part.