Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polygon/bridge: fix snapshot stores, logging, replay blocks if needed on startup #12849

Merged
merged 17 commits into from
Nov 23, 2024

Conversation

taratorio
Copy link
Member

@taratorio taratorio commented Nov 22, 2024

  1. fixes a bug with snapshot store which was causing uint64 underflow (due to 0-1) because it was not filtering out snapshot segment indices that were empty (so index.BaseDataId()+index.KeyCount()-1 = 0+0-1) in LastFrozenEntityId - this caused the milestone scrapper to be stuck forever in SynchronizeMilestone
  2. fixes a bug with bridge block replay on startup if it is behind current execution tip - this relates to situations that can happen after initial sync and snapshot download and/or during regeneration of bridge/heimdall snapshots from 0 as described here astrid: create integration commands to manually regenerate checkpoints, spans, events, etc. #12737 (comment) (hence also closes astrid: create integration commands to manually regenerate checkpoints, spans, events, etc. #12737)
  3. improves our Info logging by introducing periodic progress logging so it doesn't look like the node is stuck/not doing anything upon initial sync on Info level

@taratorio taratorio changed the title polygon/bridge: fix replay blocks if needed on startup polygon/bridge: fix snapshot stores, logging, replay blocks if needed on startup Nov 23, 2024
@taratorio taratorio marked this pull request as ready for review November 23, 2024 14:25
@taratorio taratorio enabled auto-merge (squash) November 23, 2024 19:19
@taratorio taratorio merged commit 80a1472 into main Nov 23, 2024
14 of 15 checks passed
@taratorio taratorio deleted the astrid-rebuild-snapshots branch November 23, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

astrid: create integration commands to manually regenerate checkpoints, spans, events, etc.
2 participants