Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align getModifiedAccountsByHash to getModifiedAccountsByNumber and f… #12680

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

align getModifiedAccountsByHash to getModifiedAccountsByNumber and f… #12680

wants to merge 2 commits into from
+5 −3

Conversation

lupin012
Copy link
Contributor

@lupin012 lupin012 commented Nov 8, 2024 •
edited
Loading

This PR contains two changes:

  • align getModifiedAccountByHash() to getModifiedAccountsByNumber() on txn calculations
  • I assume the txn range is: fromTxn <= values <= toTxn
    Therefore the endTxn should be min(next block) - 1
    In the sw nextBlock is equal to endBlock (endBlock is increased before)

@lupin012 lupin012 marked this pull request as ready for review November 8, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AskAlexSharov AskAlexSharov Awaiting requested review from AskAlexSharov

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lupin012