Feat/assertor release workflow #12662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perlets9
requested changes
Nov 7, 2024
There was a problem hiding this comment.
@tosettil-polimi To avoid potential issues with the new releases of Erigon 3 and to ensure compatibility with future versions of Erigon 2, it would be better to create a new workflow instead of modifying the existing one.
The target branch should be release/2.61.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assertor Release Workflow
Description
This pull request introduces several improvements to the CI/CD workflow for the Erigon project:
Generalized CI/CD Workflow: The existing CI/CD workflow has been refactored to work with any branch, not just the
mainbranch. This allows for more flexible release management, where new versions can be built and tested on different branches before being promoted tomain.Pectra Assertor Tests: A new configuration file (
config-pectra.properties) has been added to run the Pectra Assertor tests as part of the Kurtosis-based integration testing. These tests can be enabled for therelease/2.61branch.Changes
The key changes in this pull request include:
ci-cd-main-branch-docker-images.ymlworkflow to work with any branch, not justmain.config-pectra.propertiesfile for running Pectra Assertor tests.Dockerfile.releaseto use the new branch-agnostic Docker build targets.These changes will improve the overall release management and testing processes for the Erigon project, making it more flexible and robust.