optimise attestation signature verification #11940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shotasilagadze
force-pushed
the
optimise-attestation-signature-verification
branch
2 times, most recently
from
fa1ab2c
to
f3e4826
Compare
shotasilagadze
force-pushed
the
optimise-attestation-signature-verification
branch
2 times, most recently
from
0155d00
to
d861ebd
Compare
shotasilagadze
force-pushed
the
optimise-attestation-signature-verification
branch
from
d861ebd
to
c1cc8a3
Compare
Giulio2002
requested changes
Sep 11, 2024
shotasilagadze
force-pushed
the
optimise-attestation-signature-verification
branch
2 times, most recently
from
c1289e9
to
16bf096
Compare
shotasilagadze
force-pushed
the
optimise-attestation-signature-verification
branch
4 times, most recently
from
57feee0
to
c77683d
Compare
Giulio2002
requested changes
Sep 12, 2024
shotasilagadze
force-pushed
the
optimise-attestation-signature-verification
branch
from
c77683d
to
c2f617f
Compare
Giulio2002
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using signature aggregate validation now for attestation service.
pprof BEFORE the changes:
pprof AFTER the changes:
It shows to speed up the process more than 10 times. Also note that in the tests I was accumulating ALL the attestation regardless having a validator/aggregator for that specific slot/committee. But we can safely say that it would have the same speeding up effect in other cases as well.