Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace_callMany: tests and not loosing ibs state of all executed txs #11879

Merged
merged 26 commits into from
Sep 12, 2024

Conversation

JkLondon
Copy link
Member

@JkLondon JkLondon commented Sep 5, 2024

closes #11798

@JkLondon JkLondon self-assigned this Sep 10, 2024
@@ -1356,6 +1357,8 @@ func (api *TraceAPIImpl) doCallMany(ctx context.Context, dbtx kv.Tx, msgs []type
}
}

ibs.Reset()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels weird that we return ibs object which was reset. who needs an empty object.

@@ -1258,7 +1261,7 @@ func (api *TraceAPIImpl) doCallMany(ctx context.Context, dbtx kv.Tx, msgs []type
vmConfig.Tracer = &ot
}

blockCtx := transactions.NewEVMBlockContext(engine, header, parentNrOrHash.RequireCanonical, dbtx, api._blockReader, chainConfig)
blockCtx = transactions.NewEVMBlockContext(engine, header, parentNrOrHash.RequireCanonical, dbtx, api._blockReader, chainConfig)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move it before for loop

@AskAlexSharov AskAlexSharov changed the title [wip] Call many fix trace_callMany: tests and not loosing ibs state of all executed txs Sep 11, 2024
@AskAlexSharov AskAlexSharov merged commit 3b7f6b9 into main Sep 12, 2024
9 checks passed
@AskAlexSharov AskAlexSharov deleted the call-many-fix branch September 12, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eirgon3 trace_callMany not work with multiple trasaction
2 participants