add options

polygon/heimdall/client_http.go

@@ -80,22 +80,41 @@ type HttpRequest struct {
 	start   time.Time
 }
 
-func NewHttpClient(urlString string, logger log.Logger) *HttpClient {
-	httpClient := &http.Client{
-		Timeout: apiHeimdallTimeout,
+type HttpClientOption func(*HttpClient)
+
+func WithHttpRequestHandler(handler httpRequestHandler) HttpClientOption {
+	return func(client *HttpClient) {
+		client.handler = handler
+	}
+}
+
+func WithHttpRetryBackOff(retryBackOff time.Duration) HttpClientOption {
+	return func(client *HttpClient) {
+		client.retryBackOff = retryBackOff
+	}
+}
+
+func WithHttpMaxRetries(maxRetries int) HttpClientOption {
+	return func(client *HttpClient) {
+		client.maxRetries = maxRetries
 	}
-	return newHttpClient(urlString, httpClient, retryBackOff, maxRetries, logger)
 }
 
-func newHttpClient(urlString string, handler httpRequestHandler, retryBackOff time.Duration, maxRetries int, logger log.Logger) *HttpClient {
-	return &HttpClient{
+func NewHttpClient(urlString string, logger log.Logger, opts ...HttpClientOption) *HttpClient {
+	c := &HttpClient{
 		urlString:    urlString,
 		logger:       logger,
-		handler:      handler,
+		handler:      &http.Client{Timeout: apiHeimdallTimeout},
 		retryBackOff: retryBackOff,
 		maxRetries:   maxRetries,
 		closeCh:      make(chan struct{}),
 	}
+
+	for _, opt := range opts {
+		opt(c)
+	}
+
+	return c
 }
 
 const (

polygon/heimdall/client_http_test.go

@@ -53,7 +53,13 @@ func TestHeimdallClientFetchesTerminateUponTooManyErrors(t *testing.T) {
 		}, nil).
 		Times(5)
 	logger := testlog.Logger(t, log.LvlDebug)
-	heimdallClient := newHttpClient("https://dummyheimdal.com", requestHandler, 100*time.Millisecond, 5, logger)
+	heimdallClient := NewHttpClient(
+		"https://dummyheimdal.com",
+		logger,
+		WithHttpRequestHandler(requestHandler),
+		WithHttpRetryBackOff(100*time.Millisecond),
+		WithHttpMaxRetries(5),
+	)
 
 	spanRes, err := heimdallClient.FetchSpan(ctx, 1534)
 	require.Nil(t, spanRes)
@@ -72,7 +78,13 @@ func TestHeimdallClientStateSyncEventsReturnsErrNoResponseWhenHttp200WithEmptyBo
 		}, nil).
 		Times(2)
 	logger := testlog.Logger(t, log.LvlDebug)
-	heimdallClient := newHttpClient("https://dummyheimdal.com", requestHandler, time.Millisecond, 2, logger)
+	heimdallClient := NewHttpClient(
+		"https://dummyheimdal.com",
+		logger,
+		WithHttpRequestHandler(requestHandler),
+		WithHttpRetryBackOff(time.Millisecond),
+		WithHttpMaxRetries(2),
+	)
 
 	spanRes, err := heimdallClient.FetchStateSyncEvents(ctx, 100, time.Now(), 0)
 	require.Nil(t, spanRes)