Skip to content

Commit

Permalink
comment docker-build-check job as mentioned in the issue 11872. (#11873)
Browse files Browse the repository at this point in the history
comment docker-build-check job as mentioned in the issue
[11872](#11872) -- it will
save us 5-6 mins time of waiting for the routine check for each workflow
run (faster PR check, etc).

get rid of "skip-build-cache" which is removed since v5
  • Loading branch information
lystopad authored Sep 10, 2024
1 parent 25a3c7c commit f3f1e67
Showing 1 changed file with 14 additions and 15 deletions.
29 changes: 14 additions & 15 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ jobs:
uses: golangci/golangci-lint-action@v6
with:
version: v1.59.1
skip-build-cache: true
args: --help

- name: Lint
Expand Down Expand Up @@ -114,23 +113,23 @@ jobs:
- name: Test erigon-lib
run: cd erigon-lib && make test-no-fuzz

docker-build-check:
# don't run this on main - the PR must have run it to be merged and it misleads that this pushes the docker image
if: (${{ github.event_name == 'push' || !github.event.pull_request.draft }}) && ${{ github.ref != 'refs/heads/main' }}
runs-on: ubuntu-22.04

steps:
- uses: AutoModality/action-clean@v1
- uses: actions/checkout@v4
with:
fetch-depth: 0 # fetch git tags for "git describe"
# docker-build-check:
# # don't run this on main - the PR must have run it to be merged and it misleads that this pushes the docker image
# if: (${{ github.event_name == 'push' || !github.event.pull_request.draft }}) && ${{ github.ref != 'refs/heads/main' }}
# runs-on: ubuntu-22.04
#
# steps:
# - uses: AutoModality/action-clean@v1
# - uses: actions/checkout@v4
# with:
# fetch-depth: 0 # fetch git tags for "git describe"

- name: make docker (see dockerhub for image builds)
run: DOCKER_TAG=thorax/erigon:ci-$GITHUB_SHA DOCKER_UID=$(id -u) DOCKER_GID=$(id -g) make docker
# - name: make docker (see dockerhub for image builds)
# run: DOCKER_TAG=thorax/erigon:ci-$GITHUB_SHA DOCKER_UID=$(id -u) DOCKER_GID=$(id -g) make docker

# check with root permissions, should be cached from previous build
- name: sudo make docker
run: sudo DOCKER_TAG=thorax/erigon:ci-$GITHUB_SHA DOCKER_UID=$(id -u) DOCKER_GID=$(id -g) make docker
# - name: sudo make docker
# run: sudo DOCKER_TAG=thorax/erigon:ci-$GITHUB_SHA DOCKER_UID=$(id -u) DOCKER_GID=$(id -g) make docker

# automated-tests:
# runs-on:
Expand Down

0 comments on commit f3f1e67

Please sign in to comment.