Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced HTML does not trigger modal close for elements with closeClass #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danshultz
Copy link

If the html is late loaded into the modal or the html in the modal is changed, elements with the close class do not trigger close as the event is bound directly to the element vs the container element.

Since I was unsure what versions of jQuery you were supporting I used $.delegate vs $.on but please let me know if you prefer this to be changed to $.on

Thanks,
Dan

If the html is late loaded into the modal or the html in the modal is changed, elements with the close class do not trigger close as the event is bound directly to the element vs the container element.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant