Add set preset
#139
Add set preset
#139
Conversation
Sets only reported results (useful for partial runs) Signed-off-by: sagudev <[email protected]>
There was a problem hiding this comment.
suggestion: This is basically a modified ReportProcessingPreset::ResetAllOutcomes (RE: #139 (comment)). I'm not firmly settled in this opinion, but I suspect that an option that overrides this particular preset behavior, rather than a new preset, would be an easier CLI to understand (as a user) and maintain.
My suggestion is to resurrect --on-missing-from-report={delete,reconcile}-{silently,and-{info,warn}}]; I'm happy to implement that myself. I wonder if a --partial-run (name TBD) flag might be more clear WRT intent, likely as an alias (i.e. for --on-missing-from-report=keep-and-info or keep-silently).
| ReportProcessingPreset::SetNewOutcomes => |meta, rep| match rep { | ||
| Some(rep) => rep, | ||
| None => meta, | ||
| }, |
There was a problem hiding this comment.
suggestion: At first glance, this appears to be different from ResetAll WRT fallback (i.e., Set falls back to meta, rather than ResetAll's Default::default()). But as of #131, ResetAll actually doesn't ever run into the fallback case, because missing entries are deleted and skip reconciliation entirely. Huh...I hadn't considered that that wasn't exercised before. 😅
We probably want to change ResetAll to match this function body instead. 🤔 If we do, I think that strengthens the argument for a separate option (instead of a new preset) at #139 (review).
|
I saw #25, but given the last comment I though separate preset was ok. I can also do So presets determine how reconciliation happens with reported results ( |
Sets only reported results.
This is useful for partial runs (when only subset of tests are run). This is mostly useful for local development when focusing on fixing specific tests, I used this in servo a lot.
From #80