Bug 1906982 [wpt PR 47065] - [FedCM] Send SameSite=Lax cookies, in ad…

…dition to None, a=testonly Automatic update from web-platform-tests [FedCM] Send SameSite=Lax cookies, in addition to None See discussion in w3c-fedid/FedCM#587 This is behind the FedCmSameSiteLax flag for now. Bug: 350944661 Change-Id: I3e5fe99b98560f680217cd3326ff66d290a5290f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5675433 Reviewed-by: Yi Gu <[email protected]> Commit-Queue: Christian Biesinger <[email protected]> Reviewed-by: Charlie Reis <[email protected]> Cr-Commit-Position: refs/heads/main@{#1325570} -- wpt-commits: aa0082aa9066bb6064ff91636dd9d69d22e4bca3 wpt-pr: 47065
erichdongubler-mozilla · Jul 15, 2024 · 63179f6 · 63179f6
1 parent 7ef4eac
commit 63179f6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/testing/web-platform/tests/fedcm/support/accounts_check_same_site_strict.py b/testing/web-platform/tests/fedcm/support/accounts_check_same_site_strict.py
@@ -7,6 +7,7 @@ def main(request, response):
     return request_error
   if request.cookies.get(b"same_site_strict") == b"1":
     return (546, [], "Should not send SameSite=Strict cookies")
+  # TODO(crbug.com/350944661): We want to send these cookies.
   if request.cookies.get(b"same_site_lax") == b"1":
     return (547, [], "Should not send SameSite=Lax cookies")
   if request.headers.get(b"Sec-Fetch-Site") != b"cross-site":

diff --git a/testing/web-platform/tests/fedcm/support/token_check_same_site_strict.py b/testing/web-platform/tests/fedcm/support/token_check_same_site_strict.py
@@ -7,6 +7,7 @@ def main(request, response):
     return request_error
   if request.cookies.get(b"same_site_strict") == b"1":
     return (546, [], "Should not send SameSite=Strict cookies")
+  # TODO(crbug.com/350944661): We want to send these cookies.
   if request.cookies.get(b"same_site_lax") == b"1":
     return (547, [], "Should not send SameSite=Lax cookies")