Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Madmax arguments to support plotting for Chives #937

Open
wants to merge 7 commits into
base: development
Choose a base branch
from

Conversation

guydavis
Copy link
Contributor

Adds the -x (network port) and -k (plot size) options to Madmax plotter configuration. Also includes the boolean toggles of -w (wait for copy) and -G (tmp toggle). Tested this in order to create the smaller k29/k30/k31 size plots that the Chives blockchain fork uses.

Each of these new options is fully optional so their absence in existing plotman.yaml config files will simply continue to use the previous implicit defaults. This means no impact to existing Plotman users.

@altendky
Copy link
Collaborator

The basic holdup here is just general support of plots that are not valid on Chia mainnet. I want to avoid people testing a bit with k25 or such, forgetting to set it back, then plotting a pile of useless plots. #277 (comment)

So, the question to answer to get this merged is 'how do we make sure the user doesn't accidentally do the wrong thing?'.

Side note, sell this as 'supporting smaller plots for debugging' not 'chives support'. :]

Oh, and thanks!

@guydavis
Copy link
Contributor Author

guydavis commented Nov 7, 2021

Hi, sorry for the slow reply. Been busy with lots of other work. You too it looks like. Kudos on the recent Chia release with the new plotter integration. Keep up the good work!

Regarding how to protect users from plotting accidentally small plots, how about a guard on the network_port value. By default it is 8444, so would refuse to plot any k < 32. However, user sets network_port to 9699 for Chives, then would allow plotting of k between 29 and 31?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants