Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

req: add percentage complete #300

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

req: add percentage complete #300

wants to merge 1 commit into from

Conversation

Fmstrat
Copy link
Contributor

@Fmstrat Fmstrat commented May 9, 2021

Addresses #297

@Fmstrat
Copy link
Contributor Author

Fmstrat commented May 10, 2021

Display for reference:

 plot id    k              tmp                   dst   wall   phase    tmp      pid   stat   pct    mem   user    sys     io
5ac4f255   32   /data/tmp/plot   /mnt/external/plots   3:13     3:2   226G   482966    RUN   41%   5.3G   4:23   0:12   0:05
3aed4dec   32        /mnt/sdb1   /mnt/external/plots   3:56     3:2   206G   461155    DSK   52%   5.3G   4:40   0:13   0:16
7ec29aed   32        /mnt/sda1   /mnt/external/plots   4:26     3:4   184G   455588    RUN   64%   5.3G   4:54   0:15   0:24

rafaelsteil
rafaelsteil reviewed May 11, 2021
View reviewed changes
src/plotman/reporting.py
# Regular row
else:
try:
# Get percent complete
finished_log_lines = 2626
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does 2626 comes from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at the issue linked above for all the details, but that is the number of sequential log lines in a 128 plot (pulled from chia-gui sec)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Defining as a constant would be interesting just like Chia has FINISHED_LOG_LINES. I looked at the thread and compared to my own files, and they resulted in 2630 in almost all cases. Maybe 2626 is a "safer" value? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelsteil rafaelsteil rafaelsteil left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fmstrat @rafaelsteil