Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find chia in env if needed #106

Draft
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

altendky
Copy link
Collaborator

@altendky altendky commented Apr 10, 2021

Fixes #80.

Draft for:

  • Self review
  • Deal with PyPy, one way or the other
  • Make plotman runnable without a findable chia
    • I figure it could still be useful for monitoring
    • Maybe require an override, maybe make lack of chia a warning rather than an error

@altendky altendky changed the base branch from main to development April 10, 2021 02:27
@altendky
Copy link
Collaborator Author

I did run a k25 the whole way through and got a plot out the other end. I dunno, I do think plotman should be able to work without activating the environment but there are various aspects of this that make me a bit itchy. Let me know which bits do that for you.

And yeah, I may yet drop PyPy depending if Chia works with it. Which it probably doesn't.

ping: @ericaltendorf, @jkbecker, @chelseadole

Copy link
Contributor

@chelseadole chelseadole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clever solution to a finnicky situation. As is often the case with these kind of issues, there's likely a lot of room for edge cases, but I'm not sure they're worth the time they'd take to suss out, as they're likely quite specific.

The override of the user's environment makes me a bit itchy, but to be fair it's only for the duration of the single command

src/plotman/manager.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be able to find chia command without activating the env
2 participants