fix(ValidationParser): handle props that are only accessible via brac…

…ket syntax fixes aurelia#326
ericIMT · Sep 13, 2016 · 8ef6182 · 8ef6182
1 parent 7b13300
commit 8ef6182
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/src/implementation/validation-parser.ts b/src/implementation/validation-parser.ts
@@ -83,12 +83,10 @@ export class ValidationParser {
   }
 
   parseProperty<TObject, TValue>(property: string|PropertyAccessor<TObject, TValue>): RuleProperty {
-    let accessor: Expression;
     if (isString(property)) {
-      accessor = this.parser.parse(<string>property);
-    } else {
-      accessor = this.getAccessorExpression(property.toString());
-    }
+      return { name: <string>property, displayName: null };  
+    } 
+    const accessor = this.getAccessorExpression(property.toString());  
     if (accessor instanceof AccessScope
       || accessor instanceof AccessMember && accessor.object instanceof AccessScope) {      
       return {

diff --git a/test/validation-parser.ts b/test/validation-parser.ts
@@ -33,4 +33,11 @@ describe('Validator', () => {
     expect(parse('_ => _.b')).toEqual(new AccessScope('b', 0));
     expect(parse('$ => $.b')).toEqual(new AccessScope('b', 0));
   });
+
+  it('parses properties', () => {
+    expect(parser.parseProperty('firstName')).toEqual({ name: 'firstName', displayName: null });
+    expect(parser.parseProperty('3_letter_id')).toEqual({ name: '3_letter_id', displayName: null });
+    expect(parser.parseProperty('. @$# ???')).toEqual({ name: '. @$# ???', displayName: null });
+    expect(parser.parseProperty((x: any) => x.firstName)).toEqual({ name: 'firstName', displayName: null });
+  });
 });