Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #30

Merged
merged 10 commits into from
Jan 24, 2025
Merged

Improvements #30

merged 10 commits into from
Jan 24, 2025

Conversation

steel97
Copy link
Contributor

@steel97 steel97 commented Jan 24, 2025

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

This PR adds CodeQL and fixes most of it's warnings

Summary:

  • added overflow check for offset + tokens_count in send_response_attested_input_frame
  • added CodeQL workflow
  • fixed private key check in ergo_secp256k1_schnorr_p2pk_sign_init
  • docs: fixed tests run documentation
  • docs: added notes about max buffer size of Ergo Tree and Additional Registers
  • docs: added note, which indicates that Aditions Registers must be added after Tokens

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

doc/INS-20-ATTEST-BOX.md Outdated Show resolved Hide resolved
Co-authored-by: Alison Oliveira <[email protected]>
@arobsn arobsn merged commit d779206 into ergoplatform:main Jan 24, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants