Merge pull request #28 from ergoplatform/rename-start-signing

Rename `Start Signing` to `Review transaction`
ergoplatform · Nov 26, 2024 · ff30bac · ff30bac
2 parents aa699c0 + d6a47fe
commit ff30bac
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/commands/signtx/operations/stx_op_p2pk.c b/src/commands/signtx/operations/stx_op_p2pk.c
@@ -337,7 +337,7 @@ uint16_t ui_stx_operation_p2pk_show_token_and_path(sign_transaction_operation_p2
     const ux_flow_step_t *b32_step = ui_bip32_path_screen(
         ctx->bip32.path,
         ctx->bip32.len,
-        "Start Signing",
+        "Review transaction",
         ctx->ui_approve.bip32_path,
         MEMBER_SIZE(sign_transaction_operation_p2pk_ui_approve_data_ctx_t, bip32_path),
         NULL,

diff --git a/src/commands/signtx/stx_ui_nbgl.c b/src/commands/signtx/stx_ui_nbgl.c
@@ -157,7 +157,7 @@ bool ui_stx_add_transaction_screens(sign_transaction_ui_sign_confirm_ctx_t* ctx,
     nbgl_useCaseReview(TYPE_TRANSACTION,
                        &pair_list,
                        &C_app_logo_64px,
-                       "Start Signing",
+                       "Review transaction",
                        base_ctx->ui_approve.bip32_path,
                        "Sign transaction",
                        ui_stx_operation_approve_action);

diff --git a/tests/transaction-tests.js b/tests/transaction-tests.js
@@ -18,7 +18,7 @@ function signTxFlows({ device }, auth, from, to, change, tokens_to = undefined,
     flows[i++].push({ header: null, body: 'Approve' }, { header: null, body: 'Reject' });
     // accept tx screen
     if (to || change) {
-        flows[i] = [{ header: 'Start Signing', body: removeMasterNode(from.path.toString()) }];
+        flows[i] = [{ header: 'Review transaction', body: removeMasterNode(from.path.toString()) }];
     }
     // output screen
     if (to) {