Review remark from RadWolfie

ergo720 · Aug 21, 2024 · 1689004 · 1689004
1 parent cf2ae5c
commit 1689004
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/src/hw/eeprom.cpp b/src/hw/eeprom.cpp
@@ -102,12 +102,12 @@ eeprom::init(std::filesystem::path eeprom_dir)
 			m_fs = std::move(*opt);
 			m_fs.seekg(0);
 			m_fs.write((const char *)g_default_eeprom, 256);
-			if (m_fs.good()) {
-				std::memcpy(m_eeprom, g_default_eeprom, 256);
-				return true;
+			if (!m_fs.good()) {
+				logger_en(error, "Failed to update eeprom file");
+				return false;
 			}
-			logger_en(error, "Failed to update eeprom file");
-			return false;
+			std::memcpy(m_eeprom, g_default_eeprom, 256);
+			return true;
 		}
 	}
 	else {
@@ -118,10 +118,10 @@ eeprom::init(std::filesystem::path eeprom_dir)
 		m_fs = std::move(*opt);
 		m_fs.seekg(0);
 		m_fs.read((char *)m_eeprom, 256);
-		if (m_fs.good()) {
-			return true;
+		if (!m_fs.good()) {
+			logger_en(error, "Failed to copy eeprom file to memory");
+			return false;
 		}
-		logger_en(error, "Failed to copy eeprom file to memory");
-		return false;
+		return true;
 	}
 }